Feature/add api guess ca #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* targetCompatibility: JVM 11 * JavaLanguageVersion: 17 * Gradle: 8.7.1 Update ignored and included Android Studio/IntelliJ files * Add .idea/deploymentTargetSelector as git file * Set .idea/runConfigurations.xml as ignored file
* Add Carrier Aggregation cell list to model
* Add Carrier Aggregation cells API endpoints:
* /estimate-ca/all : returns a list of estimated Carrier Aggregation cells
- if more than 1 cells have the status connected, return them all as Carrier Aggregation cells
- if only a single cell is connected, take the best-RSRQ cell from the available cells (CA estimation)
* /estimate-ca/{id} : returns the cell information of a single cell
We ran into an issue that all available cells are not of type "NoneConnection" (available, but not connected), but of type "SecondaryConnection" which made the being identified as connected. Fix this by checking for "PrimaryConnection" type instead of checking for "not NoneConnection". A similar issue war reported to netmonster-core before: mroczis/netmonster-core#53
bastian-src
force-pushed
the
feature/add_api_guess_ca
branch
from
46dd8c8 to
89fa727
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of several commits, accomplishing the following:
The main feature is the following new API endpoint:
We estimate a possible CA cell by taking the cell with the best RSRQ value of all available cells. The API endpoint returns the current primary cell and the estimated CA cell.